Migrate as much as possible to pyproject.toml, stop using versioneer to manage versions, update dependencies.yaml. #232
Conversation
bdice
changed the title
bdice
changed the title
| "Programming Language :: Python :: 3.9", | ||
| ], | ||
| # Include the separately-compiled shared library | ||
| extras_require={"test": ["pytest", "pytest-xdist"]}, | ||
| packages=find_packages(exclude=["tests*"]), |
There was a problem hiding this comment.
I would reuse the find_packages result for package_data to guarantee they stay in sync.
There was a problem hiding this comment.
Yes, good call. Will do.
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| ], | ||
| packages=find_packages(exclude=["tests*"]), | ||
| include_package_data=True, |
There was a problem hiding this comment.
Not critical since kvikio doesn't have wheels, but scikit-build has bugs with include_package_data so specifying package_data explicitly (like in the non-legate setup.py) is safer. That said I don't see wheels happening for legate-kvikio anytime soon so it's mostly just to be safe.
There was a problem hiding this comment.
I'll unresolve this thread -- I'd be happy to try and fix #233 in this PR.
There was a problem hiding this comment.
Sure, if you're here and it's straightforward.
vyasr
added
improvement
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", |
There was a problem hiding this comment.
I am wondering if it is best just to remove the Python :: <version> lines? Are they used by anyone?
There was a problem hiding this comment.
They are used on pypi for classification (and presented to the user on the webpage), e.g. https://pypi.org/project/numpy/
|
@bdice, is this PR ready to be merged? |
|
/merge |
|
Thanks all! 🙏 |
Modernizes kvikio's Python build system to help with CUDA 12 migration. Some of these changes were made for other RAPIDS repos in separate PRs over the course of time but I am doing them all together in this PR to help kvikio catch up to the state of other repos.
Major changes:
pyproject.tomlfor as much metadata as possible.Closes #194. Addresses some things mentioned in #186.