Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support host memory #82

Merged
merged 20 commits into from
Aug 3, 2022
Merged

Support host memory #82

merged 20 commits into from
Aug 3, 2022

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jun 7, 2022 •
edited

Implementing support of host memory IO and some clean up of the POSIX code.

Closes #76.

cc. @jakirkham

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 7, 2022
@madsbk madsbk changed the title [WIP] Support host memory Support host memory Jun 8, 2022
@madsbk madsbk marked this pull request as ready for review June 8, 2022 11:57
@madsbk madsbk mentioned this pull request Jun 13, 2022
Closed
@rapidsai rapidsai deleted a comment from jakirkham Jun 16, 2022
@madsbk madsbk requested a review from jakirkham June 16, 2022 08:19
This was referenced Jul 27, 2022
Closed
Closed
jakirkham
jakirkham reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mads! 🙏

This looks good. Had a couple comments and questions below 🙂

cpp/examples/basic_io.cpp Outdated Show resolved Hide resolved
python/kvikio/_lib/libkvikio.pyx Outdated Show resolved Hide resolved
python/kvikio/cufile.py Outdated Show resolved Hide resolved
python/kvikio/cufile.py Outdated Show resolved Hide resolved
python/tests/test_basic_io.py Outdated Show resolved Hide resolved
@madsbk
Copy link
Member Author

madsbk commented Aug 2, 2022

Thanks Mads! pray

This looks good. Had a couple comments and questions below slightly_smiling_face

Thanks @jakirkham, I think I have addressed all of your comments.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ecbb135 into rapidsai:branch-22.08 Aug 3, 2022
@jakirkham
Copy link
Member

Thanks Mads! 🙏

@madsbk madsbk deleted the support_host_memory branch August 5, 2022 12:00
vuule pushed a commit to vuule/kvikio that referenced this pull request Nov 8, 2023
@mroeschke
Merge pull request rapidsai#82 from mroeschke/bug/index/dataframe_error
fe06a0b 
Raise ValueError for `cudf.Index(cudf.DataFrame(...))`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing a mix of host & device frames doesn't work
3 participants
@madsbk @jakirkham @quasiben