Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] linalg::axpy mdspan functions need gtests #873

Closed
cjnolet opened this issue Oct 3, 2022 · 0 comments · Fixed by #942
Closed

[BUG] linalg::axpy mdspan functions need gtests #873

cjnolet opened this issue Oct 3, 2022 · 0 comments · Fixed by #942
Assignees
@benfred
Labels
bug Something isn't working
Projects
RAFT v22.12 Release

Comments

@cjnolet
Copy link
Member

cjnolet commented Oct 3, 2022 •
edited
Loading

There were several syntax errors in this file which were not caught by the RAFT CI because we don't have proper tests for these. These were only found by a cuml build, which is not good.
@cjnolet cjnolet added the bug Something isn't working label Oct 3, 2022
@cjnolet cjnolet added this to Issue-Needs prioritizing in RAFT v22.12 Release via automation Oct 3, 2022
@cjnolet cjnolet moved this from Issue-Needs prioritizing to Blockers (CI / build / tests / others) in RAFT v22.12 Release Oct 7, 2022
@benfred benfred assigned benfred and unassigned divyegala Oct 21, 2022
benfred added a commit to benfred/raft that referenced this issue Oct 21, 2022
@benfred
Add unittest for linalg::axpy
7b55af9 
Closes rapidsai#873
@benfred benfred mentioned this issue Oct 21, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #942 Oct 27, 2022
rapids-bot bot pushed a commit that referenced this issue Oct 27, 2022
@benfred
Add unittest for linalg::axpy (#942)
ced7bce 
Closes #873
Closes #944

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #942
RAFT v22.12 Release automation moved this from Blockers (CI / build / tests / others) to Done Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
bug Something isn't working
Projects
VS/ML/DM Primitives Release Board
Archived in project
RAFT v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unittest for linalg::axpy benfred/raft
3 participants
@benfred @cjnolet @divyegala