Python API for IVF-Flat serialization #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
improvement
tfeher
commented
May 16, 2023
tfeher
force-pushed
the
fea_ivf_flat_serialize
branch
from
349096b
to
cbcbadd
Compare
cjnolet
reviewed
May 18, 2023
tfeher
force-pushed
the
fea_ivf_flat_serialize
branch
from
f105956
to
acf589b
Compare
tfeher
commented
May 19, 2023
| if (!index) { RAFT_FAIL("Invalid index pointer"); } \ | ||
| *index = raft::neighbors::ivf_flat::deserialize<DTYPE, int64_t>(handle, filename); \ | ||
| }; \ | ||
| void serialize(raft::resources const& handle, \ |
There was a problem hiding this comment.
Note that this is not used by the current PR (only (de)serialize_file is used). But I think this can be used to fix rapidsai/cuml#4743, that motivates to keep it in the PR.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python API for IVF-Flat serialization.
closes #752