Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build.sh to enable NEIGHBORS_ANN_CAGRA_TEST #1724

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Fix build.sh to enable NEIGHBORS_ANN_CAGRA_TEST #1724

merged 6 commits into from
Aug 10, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Aug 8, 2023

This PR update build.sh to enable NEIGHBORS_ANN_CAGRA_TEST.

@enp1s0 enp1s0 requested a review from a team as a code owner August 8, 2023 05:45
@enp1s0 enp1s0 self-assigned this Aug 8, 2023
@enp1s0 enp1s0 added bug Something isn't working non-breaking Non-breaking change labels Aug 8, 2023
bdice
bdice approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake approval.

bdice
bdice reviewed Aug 8, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
bdice
bdice reviewed Aug 8, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
bdice
bdice requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple small things after approving, requesting changes for that.

bdice
bdice reviewed Aug 8, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
enp1s0 and others added 4 commits August 9, 2023 09:30
@enp1s0 @bdice
Update build.sh
fbad5bc 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@enp1s0 @bdice
Update build.sh
92cbebc 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@enp1s0 @bdice
Update build.sh
9c5cd74 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@enp1s0
Alphabetize test list
b97071a
@enp1s0
Copy link
Member Author

enp1s0 commented Aug 9, 2023

Thanks @bdice for reviewing the changes. I have fixed the issues.

@cjnolet
Copy link
Member

cjnolet commented Aug 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit bc8850a into rapidsai:branch-23.10 Aug 10, 2023
57 checks passed
@enp1s0 enp1s0 deleted the fix-buildsh-to-enable-CAGRA-test branch August 10, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@bdice bdice bdice approved these changes

Assignees

@enp1s0 enp1s0

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enp1s0 @cjnolet @bdice