Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting end-to-end start time so it doesn't include stream creation time #1989

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 13, 2023

We can safely assume all cuda streams have been created before we run benchmark experiments. With the sensitivity to latencies for smaller batch sizes, this has an impact on overall throughput.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Nov 13, 2023
@cjnolet cjnolet requested a review from a team as a code owner November 13, 2023 22:09
@github-actions github-actions bot added the cpp label Nov 13, 2023
@cjnolet cjnolet self-assigned this Nov 13, 2023
@cjnolet cjnolet requested a review from a team as a code owner November 14, 2023 00:31
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@cjnolet
Copy link
Member Author

cjnolet commented Nov 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9f84648 into rapidsai:branch-23.12 Nov 14, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants