Add FAISS with RAFT enabled Benchmarking to raft-ann-bench #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
tfeher
requested changes
Jun 13, 2024
| @@ -208,7 +234,7 @@ void FaissGpu<T>::build(const T* dataset, size_t nrow, cudaStream_t stream) | |||
| nlist_, | |||
| index_ivf->cp.min_points_per_centroid); | |||
| } | |||
| index_ivf->cp.max_points_per_centroid = max_ppc; | |||
| index_ivf->cp.max_points_per_centroid = 300; | |||
There was a problem hiding this comment.
Could you change it back to max_ppc?
| base: | ||
| build: | ||
| nlist: [2048] | ||
| ratio: [1, 4, 10] |
There was a problem hiding this comment.
I would not add multiple build ratios, just pick one.
|
/ok to test |
tfeher
approved these changes
Jun 13, 2024
|
/ok to test |
1 similar comment
|
/ok to test |
|
/merge |
jameslamb
approved these changes
Jun 17, 2024
| @@ -115,4 +116,4 @@ endfunction() | |||
| find_and_configure_faiss( | |||
| BUILD_STATIC_LIBS ${RAFT_USE_FAISS_STATIC} | |||
| ENABLE_GPU ${RAFT_FAISS_ENABLE_GPU} | |||
| ) | |||
| ) | |||
There was a problem hiding this comment.
I noticed several files in this PR that do not end with a newline.
In practice I've found that this rarely matters, but it can occasionally cause issues for tools doing line-by-line parsing of files. In a future PR, you may want to consider automatically fixing these with pre-commit, like cudf does: https://github.com/rapidsai/cudf/blob/107753ccaacdb62287c4dd4351e5caf3bf8bc62a/.pre-commit-config.yaml#L13
benfred
approved these changes
Jun 17, 2024
|
|
||
|
|
||
| def faiss_gpu_ivf_pq_build_constraints(params, dims): | ||
| ret = True |
Comment on lines
+62
to
+64
| pq_bits = 8 | ||
| if "bitsPerCode" in params: | ||
| pq_bits = params["bitsPerCode"] |
There was a problem hiding this comment.
nitpick:
Suggested change
| pq_bits = 8 | |
| if "bitsPerCode" in params: | |
| pq_bits = params["bitsPerCode"] | |
| pq_bits = params.get("bitsPerCode", 8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faiss_gpu_ivf_flat,faiss_gpu_ivf_pqget_faiss.cmakeNotes: The
StandardGpuResourcesobject is part of FAISS' index classes. As a result, there is no way of creating a separate Raft handle for each thread without creating a new instance of the whole index object for a new thread. As such, multi-threaded benchmarking for GPU indices will not work.For CPU indices, @divyegala had seen some other issues. Though this PR is mainly about raft-enabled FAISS GPU indices.