Fixing cusparse aligned address issue and adding note #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
Feb 12, 2024
…ake sure we fail until there's a better fix
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
…to bug-cuda122-cusparse-bug
jakirkham
reviewed
Feb 12, 2024
divyegala
approved these changes
Feb 12, 2024
jakirkham
reviewed
Feb 12, 2024
jakirkham
reviewed
Feb 12, 2024
bdice
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Changes seem fine -- can we add a PR description and cross-link the previous PRs that changed / reverted this code? We've been back-and-forth a few times so I want to make sure the history can be understood by a future reader (someone will have to make sense of this when removing the 12.2 workaround).
|
In searching I found these PRs, but am not sure whether they are relevant (or how they fit into this context) Would really appreciate if someone could let us know |
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.