Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding distance specializations #376

Merged
merged 24 commits into from
Dec 15, 2021
Merged

Adding distance specializations #376

merged 24 commits into from
Dec 15, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 15, 2021

This adds new export targets for distance specializations that speed up building and re-building by 1) increasing parallelism / compilation units, and 2) reuses compiled object files across different compilation units.

@cjnolet cjnolet requested review from a team as code owners November 15, 2021 22:31
@cjnolet cjnolet changed the base branch from branch-21.12 to branch-22.02 November 15, 2021 22:31
@cjnolet cjnolet requested a review from a team as a code owner November 15, 2021 22:31
@cjnolet cjnolet changed the base branch from branch-22.02 to branch-21.12 November 15, 2021 22:33
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2021
@cjnolet cjnolet changed the base branch from branch-21.12 to branch-22.02 November 15, 2021 23:27
@cjnolet cjnolet changed the base branch from branch-22.02 to branch-21.12 November 16, 2021 15:42
@cjnolet cjnolet added this to PR-WIP in RAFT v22.02 Release via automation Nov 16, 2021
@github-actions github-actions bot removed the gpuCI label Nov 17, 2021
@ajschmidt8
Copy link
Member

@cjnolet, should this be targeting 22.02?

@cjnolet cjnolet changed the base branch from branch-21.12 to branch-22.02 November 17, 2021 18:58
divyegala
divyegala approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

cpp/include/raft/sparse/selection/knn_graph.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/knn_graph.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/selection/knn_graph.cuh Outdated Show resolved Hide resolved
RAFT v22.02 Release automation moved this from PR-WIP to PR-Reviewer approved Dec 6, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Dec 15, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 681b19d into rapidsai:branch-22.02 Dec 15, 2021
RAFT v22.02 Release automation moved this from PR-Reviewer approved to Done Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
RAFT v22.02 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjnolet @ajschmidt8 @divyegala