Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-format style errors #425

Merged
merged 6 commits into from
Dec 17, 2021

Conversation

achirkin
Copy link
Contributor

Looks like a few style errors slipped through in one of the last commits preventing other PR from passing their CI checks. This PR fixes that.

@achirkin achirkin requested review from a team as code owners December 17, 2021 07:19
@github-actions github-actions bot added the cpp label Dec 17, 2021
@achirkin achirkin added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Dec 17, 2021
@MatthiasKohl
Copy link
Contributor

Most likely due to #412 which changes the include order for some files slightly.
I'll add some further suggestions.

achirkin and others added 4 commits December 17, 2021 11:10
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Co-authored-by: Matt Joux <matthias.kohl@hotmail.de>
Copy link
Contributor

@MatthiasKohl MatthiasKohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the style errors, looks good to me.

@cjnolet
Copy link
Member

cjnolet commented Dec 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c05c1fa into rapidsai:branch-22.02 Dec 17, 2021
@achirkin achirkin deleted the fix-clang-format-errors branch March 31, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants