Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated .hpp headers #753

Closed
wants to merge 7 commits into from
Closed

Remove deprecated .hpp headers #753

wants to merge 7 commits into from

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jul 26, 2022

Remove deprecated headers of 22.06 and 22.08 and change the includes accordingly.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 28, 2022
@cjnolet cjnolet added this to PR-WIP in RAFT v22.10 Release via automation Jul 28, 2022
@lowener lowener mentioned this pull request Aug 8, 2022
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Sep 8, 2022
@lowener
Remove Raft deprecated headers (#4858)
6f42ced 
This should be merged before the Raft PR: rapidsai/raft#753.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - William Hicks (https://github.com/wphicks)

URL: #4858
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet cjnolet removed this from PR-WIP in RAFT v22.10 Release Oct 2, 2022
@cjnolet cjnolet added this to PR-WIP in RAFT v22.12 Release via automation Oct 2, 2022
@lowener lowener mentioned this pull request Nov 22, 2022
Closed
@lowener
Copy link
Contributor Author

lowener commented Nov 22, 2022 •
edited

Closing in favor of this more recent PR #1041.

@lowener lowener closed this Nov 22, 2022
RAFT v22.12 Release automation moved this from PR-WIP to Done Nov 22, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@lowener
Remove Raft deprecated headers (rapidsai#4858)
fafa5e3 
This should be merged before the Raft PR: rapidsai/raft#753.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lowener lowener

Labels
breaking Breaking change CMake cpp improvement Improvement / enhancement to an existing function inactive-30d
Projects
No open projects
RAFT v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lowener @cjnolet