Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build python using conda in GPU jobs #1017

Merged
merged 1 commit into from
May 9, 2022
Merged

Build python using conda in GPU jobs #1017

merged 1 commit into from
May 9, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Apr 5, 2022 •
edited
Loading

This PR convert the from sources build we are doing in GPU test job to a conda build. This is done for the following reasons:

  • This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  • This is required to start using conda compilers and mamba to build RAPIDS packages
  • This prevent us from manually managing and installing the dependencies in GPU job
  • This ensure the packages can be installed
  • This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested.

This may increase the global pipeline time, but the usage of mamba should resolve this as mamba is faster than conda to build packages

@jjacobelli jjacobelli added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 5, 2022
@jjacobelli jjacobelli self-assigned this Apr 5, 2022
@jjacobelli jjacobelli added this to PR-WIP in v22.06 Release via automation Apr 5, 2022
@github-actions github-actions bot added the gpuCI label Apr 5, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 5, 2022 12:37
@jjacobelli jjacobelli requested a review from a team as a code owner April 5, 2022 12:37
@jjacobelli jjacobelli marked this pull request as draft April 15, 2022 09:45
@jjacobelli jjacobelli added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 15, 2022
@jjacobelli
Build python using conda in GPU jobs
26e2f60 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 25, 2022 09:38
sevagh
sevagh reviewed May 9, 2022
View reviewed changes
ci/gpu/build.sh Show resolved Hide resolved
v22.06 Release automation moved this from PR-WIP to PR-Reviewer approved May 9, 2022
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 34e3fd8 into rapidsai:branch-22.06 May 9, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevagh sevagh sevagh left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@jjacobelli jjacobelli

Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjacobelli @ajschmidt8 @sevagh