Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for module-level API #1091

Merged
merged 13 commits into from
Aug 23, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 23, 2022

Description

This PR's primary intention is to fix the rmm module API documentation so that classes like DeviceBuffer appear, and to remove documentation for the rmm.rmm submodule in favor of the top-level API that defines all public names. I fixed all warnings that appear when building with Sphinx, and addressed a few other minor issues that didn't deserve their own PRs but were important to fix. I rendered the docs locally and the difference is very substantial -- parameter docstrings, public properties of classes, and other names now automatically appear or render correctly where they weren't before.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners August 23, 2022 00:40
@bdice bdice self-assigned this Aug 23, 2022
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Aug 23, 2022
@github-actions github-actions bot added conda Python Related to RMM Python API labels Aug 23, 2022
@bdice bdice added this to PR-WIP in v22.10 Release via automation Aug 23, 2022
@@ -39,7 +45,6 @@
"IPython.sphinxext.ipython_directive",
"nbsphinx",
"recommonmark",
"sphinx.ext.napoleon",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this extension was causing havoc with the docs. A lot of things weren't rendering properly, and I would guess it was because of napoleon interacting poorly with Cython-generated docs or a conflict with some other Sphinx extension. The numpydoc extension is sufficient to use on its own nowadays, and napoleon isn't needed here.

python/rmm/__init__.py Outdated Show resolved Hide resolved
v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 23, 2022
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment and sphinx edits look good.

@bdice
Copy link
Contributor Author

bdice commented Aug 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6eb255d into rapidsai:branch-22.10 Aug 23, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants