Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for nightly tests #1186

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Conversation

ajschmidt8
Copy link
Member

Description

Due to some limitations on the number of reusable workflows that can be used in a given GH Action workflow, I need to switch the nightly workflow files (build.yaml and test.yaml) to use workflow_dispatch instead of workflow_call.

Because of this switch, we can also remove the hardcoded repo field in {build,test}.yaml.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 2, 2023
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner January 2, 2023 19:19
@ajschmidt8
Copy link
Member Author

cc: @bdice, we'll have to make these changes for all of the repos.

I'll start opening PRs for the repos that have already been merged.

Here's a quick sed command that can be run from the root of each project to make the changes programmatically:

sed -i 's/workflow_call/workflow_dispatch/; /repo:/d' ./.github/workflows/{build,test}.yaml

@ajschmidt8
Copy link
Member Author

admin merging since changes are benign and not tested in PRs.

@ajschmidt8 ajschmidt8 merged commit 7fb45d4 into branch-23.02 Jan 2, 2023
@ajschmidt8 ajschmidt8 deleted the update-workflows branch January 2, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant