Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove specification of manual stage for check_style.sh script. #1214

Merged
merged 1 commit into from
Feb 21, 2023
Merged

CI: Remove specification of manual stage for check_style.sh script. #1214

merged 1 commit into from
Feb 21, 2023

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Feb 17, 2023 •
edited
Loading

Description

Do not explicitly specify to run the "manual" stage when running pre-commits as part of the ci/check_style.sh script.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@csadorf
Remove specification of manual stage for check_style.sh script.
9dcb6a4 
Do not explicitly specify to run the "manual" stage when running pre-commits as part of the ci/check_style.sh script.
@csadorf csadorf requested a review from a team as a code owner February 17, 2023 14:47
@github-actions github-actions bot added the ci label Feb 17, 2023
@csadorf csadorf changed the title Remove specification of manual stage for check_style.sh script. CI: Remove specification of manual stage for check_style.sh script. Feb 17, 2023
@vyasr vyasr added 3 - Ready for review Ready for review by team tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 17, 2023
vyasr
vyasr approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vyasr
Copy link
Contributor

vyasr commented Feb 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit f3113d9 into rapidsai:branch-23.04 Feb 21, 2023
@csadorf csadorf deleted the ci-remove-manual-stage-spec-for-style-check-pre-commit-runs branch February 22, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@csadorf csadorf

Labels
3 - Ready for review Ready for review by team ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@csadorf @vyasr @ajschmidt8