Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rapids-dependency-file-generator via pre-commit #1217

Merged
merged 7 commits into from
Feb 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 21, 2023

Description

This feature is enabled by the most recent release of dfg. This changes also allows us to disable the dfg CI check as it is now redundant.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 21, 2023
@vyasr vyasr requested a review from a team as a code owner February 21, 2023 21:47
@vyasr vyasr self-assigned this Feb 21, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Feb 22, 2023

Converting to draft pending some discussions on rapidsai/shared-workflows#46.

@vyasr vyasr marked this pull request as draft February 22, 2023 18:54
.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@vyasr vyasr marked this pull request as ready for review February 24, 2023 18:16
@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit ef997db into rapidsai:branch-23.04 Feb 24, 2023
@vyasr vyasr deleted the feat/dfg_pre_commit branch February 24, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants