Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pyproject.toml dependencies using dfg #1219

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 23, 2023

Description

This PR updates dependencies.yaml to also generates the relevant dependency sections of pyproject.toml.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 2 - In Progress Currently a work in progress non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 23, 2023
@vyasr vyasr self-assigned this Feb 23, 2023
@github-actions github-actions bot added the Python Related to RMM Python API label Feb 23, 2023
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vyas! 🙏

Had a few comments about changes in the pyproject.toml and whether we can address these in dependencies.yaml

dependencies.yaml Outdated Show resolved Hide resolved
python/pyproject.toml Outdated Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
Copy link
Contributor Author

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments John. This PR isn't quite ready for prime-time yet, but you did catch a couple of important issues for us to address before it's ready 🙂

python/pyproject.toml Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
python/pyproject.toml Outdated Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
@jakirkham
Copy link
Member

Ah sorry. Was mainly excited to see the increased usage of pyproject.toml 🙂

Happy to hold off further review until things are more ready 👍

@vyasr vyasr force-pushed the feat/pyproject_dependencies_yaml branch from abb0363 to 189552e Compare March 1, 2023 00:10
@vyasr vyasr force-pushed the feat/pyproject_dependencies_yaml branch from 189552e to e668179 Compare March 8, 2023 16:05
@vyasr vyasr added 3 - Ready for review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 8, 2023
@vyasr vyasr marked this pull request as ready for review March 8, 2023 16:07
@vyasr vyasr requested a review from a team as a code owner March 8, 2023 16:07
@vyasr
Copy link
Contributor Author

vyasr commented Mar 8, 2023

@jakirkham this is ready for review now 🙂

@vyasr vyasr requested a review from jakirkham March 8, 2023 16:08
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what benefit we are getting from the new sections in dependencies.yaml. See comments.

dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
@vyasr vyasr requested a review from bdice March 15, 2023 12:38
@vyasr
Copy link
Contributor Author

vyasr commented Mar 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit e8fbd06 into rapidsai:branch-23.04 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants