Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor oversights in the conversion to pyproject.toml #1226

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 24, 2023

Description

There were a couple of issues that accidentally made it through in #1151.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 24, 2023
@vyasr vyasr requested a review from a team as a code owner February 24, 2023 22:38
@vyasr vyasr self-assigned this Feb 24, 2023
@github-actions github-actions bot added the Python Related to RMM Python API label Feb 24, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, the reasons for these changes are:

Let me know if that's correct. Approving.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

You're right about the first two. You're also right about zip-safe being deprecated, but we decided that we should keep it for safety until we move all the way away from setuptools. I didn't delete it, I moved it from pyproject.toml to setup.py because that is one of the keys that don't work in pyproject.toml with scikit-build.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit fd6cdde into rapidsai:branch-23.04 Feb 24, 2023
@vyasr vyasr deleted the fix/pyproject_errors branch February 24, 2023 23:10
@jakirkham
Copy link
Member

I moved it [zip-safe] from pyproject.toml to setup.py because that is one of the keys that don't work in pyproject.toml with scikit-build

Ah ok. Good to have this context. Thanks Vyas! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants