Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder parameters in RMM_EXPECTS #1286

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Reorder parameters in RMM_EXPECTS #1286

merged 1 commit into from
Jun 2, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 2, 2023

Description

Resolves #1172

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function cpp Pertains to C++ code labels Jun 2, 2023
@vyasr vyasr requested a review from a team as a code owner June 2, 2023 18:07
@vyasr vyasr self-assigned this Jun 2, 2023
@vyasr vyasr requested review from rongou and jrhemstad June 2, 2023 18:07
@vyasr
Copy link
Contributor Author

vyasr commented Jun 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8b3e2c4 into rapidsai:branch-23.08 Jun 2, 2023
37 checks passed
@vyasr vyasr deleted the feat/reorder_rmm_expects branch June 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for review Ready for review by team cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap argument order in RMM_EXPECTS
2 participants
@vyasr @rongou