Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python bindings for limiting_resource_adaptor #1327

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Add Python bindings for limiting_resource_adaptor #1327

merged 5 commits into from
Aug 21, 2023

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Aug 21, 2023 •
edited
Loading

Description

Add Python bindings for the limiting_resource_adaptor via a new Python memory resource LimitingResourceAdaptor.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pentschev pentschev requested a review from a team as a code owner August 21, 2023 13:46
@github-actions github-actions bot added the Python Related to RMM Python API label Aug 21, 2023
wence-
wence- reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor quibbles, but overall looks great.

python/rmm/tests/test_rmm.py Outdated Show resolved Hide resolved
python/rmm/tests/test_rmm.py Outdated Show resolved Hide resolved
python/rmm/tests/test_rmm.py Show resolved Hide resolved
@wence- wence- added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 21, 2023
@pentschev pentschev mentioned this pull request Aug 21, 2023
Merged
vyasr
vyasr approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small suggestion, will apply then merge.

python/rmm/tests/test_rmm.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Aug 21, 2023

/merge

@pentschev
Copy link
Member Author

Thanks @vyasr !

@pentschev
Copy link
Member Author

And thanks @wence- as well! 😄

@rapids-bot rapids-bot bot merged commit 2a9fe71 into rapidsai:branch-23.10 Aug 21, 2023
44 checks passed
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Aug 22, 2023
@pentschev
Enable maximum pool size for RMM async allocator (#1221)
def2e69 
In addition to the `release_threshold`, enable as well support for the `maximum_pool_size`. The difference between the two is that `release_threshold` will attempt to bring RMM's memory usage down to that value after the next stream synchronization, whereas `maximum_pool_size` is a hard limit enforced by RMM.

Depends on rapidsai/rmm#1327.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #1221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pentschev @vyasr @wence-