Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings as errors for Python tests #1551

Merged
merged 3 commits into from
May 2, 2024
Merged

Enable warnings as errors for Python tests #1551

merged 3 commits into from
May 2, 2024

Conversation

mroeschke
Copy link
Contributor

Description

As part of rapidsai/build-planning#26, warnings in Python tests will cause that test to fail.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner May 1, 2024 21:50
@github-actions github-actions bot added the Python Related to RMM Python API label May 1, 2024
wence-
wence- requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a pyproject.toml section

python/rmm/pyproject.toml Show resolved Hide resolved
@wence- wence- added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 2, 2024
@wence-
Copy link
Contributor

wence- commented May 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 363e4c6 into rapidsai:branch-24.06 May 2, 2024
52 checks passed
@mroeschke mroeschke deleted the tests/wae branch May 2, 2024 20:54
@mroeschke mroeschke mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroeschke @wence-