rmm needs to link to nvtx3::nvtx3-cpp to support installed nvtx3 #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
|
Blocked on: rapidsai/rapids-cmake#617 |
vyasr
approved these changes
May 23, 2024
robertmaynard
force-pushed
the
bug/support_using_installed_nvxt3
branch
2 times, most recently
from
59ce78d
to
27291b2
Compare
trxcllnt
approved these changes
May 23, 2024
|
/merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If nvtx3 is already installed on the system via rapids-cmake rmm fails to link since it uses the non-namespaced target names.
Checklist