Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Test custom rapids-cmake #1584

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Test custom rapids-cmake #1584

wants to merge 1 commit into from

Conversation

PointKernel
Copy link
Member

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel mentioned this pull request Jun 12, 2024
Merged
12 tasks
@PointKernel
Copy link
Member Author

Closing this as all tests passed.

rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Jun 24, 2024
@sleeepyjack
Bump CCCL version to include cuda::std::span fix (#631)
5d47273 
This PR updates the CCCL version to include a fix for `cuda::std::span` which is required for cuCollections to work properly with CCCL 2.5.0. 

Most of the changes between the last CCCL version bump (#607) and this one were related to doc updates and unit test fixes, so I don't expect much functional impact for RAPIDS.

After this PR we likely have to bump the cuco version again to include the new changes.

### CCCL PR:

- NVIDIA/cccl#1836

### CUCO PR:

- NVIDIA/cuCollections#502

### RAPIDS PRs:

- [x] rapidsai/cudf#15986
  - [error during docs-build](https://github.com/rapidsai/cudf/actions/runs/9406273871/job/25911619452?pr=15946#step:9:2243) but seems unrelated
- [x] rapidsai/cugraph#4483
  - some CI jobs ran into a network timeout -> rerunning
- [x] rapidsai/cuml#5924
  - successful apart from some optional conda python tests
- [x] rapidsai/raft#2358
  - This one is weird as it [shows an error](https://github.com/rapidsai/raft/actions/runs/9475150045/job/26109283214?pr=2358#step:7:824) that is similar to the one we found in cuco when bumping the CCCL version to 2.5.0. However, we thought the problem was on cuco's end and pushed a fix that resolved the issue (see [Slack thread](https://nvidia.slack.com/archives/CCP05T27R/p1718060955876199))
- [x] rapidsai/rmm#1584

Authors:
  - Daniel Jünger (https://github.com/sleeepyjack)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@PointKernel