Avoid --find-links in wheel jobs #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
jameslamb
changed the title
jameslamb
added
3 - Ready for review
vyasr
approved these changes
Jun 24, 2024
|
Thanks for taking a look @vyasr ! |
|
/merge |
This was referenced Jun 27, 2024
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Jul 3, 2024
Contributes to rapidsai/build-planning#69. Proposes a stricter pattern for passing a `libkvikio` wheel from the `wheel-build-cpp` job that produced it into the `wheel-build-python` job wanting to use it (as a build dependency of `kvikio`). This change improves the likelihood that issues with the `libkivkio` wheels will be caught in CI. ## Notes for Reviewers See rapidsai/rmm#1586 and rapidsai/build-planning#69 (comment) for details on how I tested this approach. I didn't propose this on #369 because I hadn't quite finished testing the approach yet. But I do think we should do this for all of the C++ wheels (rapidsai/build-planning#33). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) URL: #397
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jul 3, 2024
Contributes to rapidsai/build-planning#69 Contributes to rapidsai/build-planning#33 Proposes a stricter pattern for passing a `pylibcugraph` wheel from the `wheel-build-cpp` job that produced it into the `wheel-build-python` job wanting to use it (as a build dependency of `cugraph`). This change improves the likelihood that issues with the `pylibcugraph` wheels will be caught in CI. ## Notes for Reviewers See rapidsai/rmm#1586 and rapidsai/build-planning#69 (comment) for details on how I tested this approach. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) URL: #4509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#69.
Proposes a stricter pattern for passing a
librmmwheel from thewheel-build-cppjob that produced it into thewheel-build-pythonjob wanting to use it (as a build dependency ofrmm). This change improves the likelihood that issues with thelibrmmwheels will be caught in CI.Checklist
Notes for Reviewers
How I tested this
Added unsatisfiable requirements
setuptools<65, setuptools>66to thelibrmmwheel (this commit).With no changes to the build scripts here, saw CI happily ignore that and succeed despite that issue: (build link).
Switched to the approach documented in Remove uses of 'pip --find-links' in CI build-planning#69 (comment), saw CI fail in the expected way (build link)