Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the build directory of rmm to be used for find_package(rmm) #698

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Allow the build directory of rmm to be used for find_package(rmm) #698

merged 2 commits into from
Feb 12, 2021

Conversation

robertmaynard
Copy link
Contributor

This folds into the rework for libcudf to support export targets ( rapidsai/cudf#7107 ).

Developers that are iterating on rmm and cudf should be able cudf against a local build of rmm without having to re-install rmm each time they change a rmm header. This MR supports this use-case by allowing find_package(rmm) to work with a rmm build directory.

To verify this ( using rapidsai/cudf#7107 ) the following will make sure cudf detects your local rmm instead of fetching it via CPM.

cmake -S cudf/cpp -B cudf/cpp/cudf -DCMAKE_PREFIX_PATH=<rmm_build_dir>

@robertmaynard robertmaynard requested a review from a team as a code owner February 11, 2021 20:58
@github-actions github-actions bot added the CMake label Feb 11, 2021
@kkraus14 kkraus14 added this to PR-WIP in v0.19 Release via automation Feb 11, 2021
@kkraus14 kkraus14 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 11, 2021
@germasch
Copy link
Contributor

FWIW, looks good to me ;)

trxcllnt
trxcllnt approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 12, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7b03ff2 into rapidsai:branch-0.19 Feb 12, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 12, 2021
@robertmaynard robertmaynard deleted the fix/cmake-exports branch February 23, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robertmaynard @germasch @kkraus14 @trxcllnt