Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include SetGPUArchs in the top-level CMakeLists.txt #713

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

trxcllnt
Copy link
Contributor

Fixes an issue seen when building both tests and benchmarks:

######################
# Configuring librmm #
######################
...
-- RMM: Building tests with GPU Architectures: 60-real;70-real;75-real;80
...
-- RMM: Building benchmarks with GPU Architectures: 60-real-real;70-real-real;75-real-real;80
-- Configuring done
CMake Error in benchmarks/CMakeLists.txt:
  Uknown CUDA architecture specifier "real-real".

@trxcllnt trxcllnt requested a review from a team as a code owner February 21, 2021 22:07
@github-actions github-actions bot added CMake cpp Pertains to C++ code labels Feb 21, 2021
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Feb 21, 2021
@kkraus14 kkraus14 added this to PR-WIP in v0.19 Release via automation Feb 21, 2021
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@kkraus14
Copy link
Contributor

@gpucibot merge

v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 22, 2021
@rapids-bot rapids-bot bot merged commit 47680ec into rapidsai:branch-0.19 Feb 22, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 22, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake cpp Pertains to C++ code non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants