Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify log file name behaviour in docs #722

Merged
merged 10 commits into from
Mar 18, 2021
Merged

Clarify log file name behaviour in docs #722

merged 10 commits into from
Mar 18, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Mar 9, 2021 •
edited
Loading

  • Adds docs describing the.dev{id} suffix to the log file name
  • Moves the responsibility of suffixing the log file name to the higher level APIs _initialize and enable_logging

@shwina shwina requested a review from a team as a code owner March 9, 2021 15:19
@github-actions github-actions bot added the Python Related to RMM Python API label Mar 9, 2021
@shwina shwina marked this pull request as draft March 9, 2021 15:22
rlratzel
rlratzel approved these changes Mar 10, 2021
View reviewed changes
Copy link

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much for working on this. I have just one question for my own understanding, but nothing to hold up my approval.

python/rmm/_lib/memory_resource.pyx Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added this to PR-WIP in v0.19 Release via automation Mar 16, 2021
@shwina shwina added feature request New feature or request non-breaking Non-breaking change labels Mar 18, 2021
@shwina shwina marked this pull request as ready for review March 18, 2021 15:19
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 18, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3c6450d into rapidsai:branch-0.19 Mar 18, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 18, 2021
@kkraus14 kkraus14 mentioned this pull request Mar 18, 2021
Closed
@ajschmidt8 ajschmidt8 mentioned this pull request Mar 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shwina @kkraus14 @rlratzel @ajschmidt8