Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Clang Version to 11.0.0 #814

Merged
merged 7 commits into from
Jul 6, 2021
Merged

Updating Clang Version to 11.0.0 #814

merged 7 commits into from
Jul 6, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jun 25, 2021 •
edited
Loading

Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for rapidsai/rmm

Depends on: rapidsai/integration#304

@codereport codereport added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 25, 2021
@codereport codereport self-assigned this Jun 25, 2021
@codereport codereport requested review from a team as code owners June 25, 2021 21:22
@codereport codereport added this to PR-WIP in v21.08 Release via automation Jun 25, 2021
@github-actions github-actions bot added conda cpp Pertains to C++ code labels Jun 25, 2021
@github-actions github-actions bot added the gpuCI label Jun 25, 2021
@codereport codereport added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jun 25, 2021
cwharris
cwharris approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.clang-format Show resolved Hide resolved
ci/checks/style.sh Outdated Show resolved Hide resolved
include/rmm/mr/host/new_delete_resource.hpp Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI label Jun 28, 2021
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 5 - DO NOT MERGE Hold off on merging; see PR for details 3 - Ready for review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jun 28, 2021
@codereport codereport mentioned this pull request Jun 28, 2021
Merged
v21.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jun 28, 2021
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Reviewer Waiting for reviewer to review or respond labels Jun 28, 2021
@codereport
Copy link
Contributor Author

rerun tests

2 similar comments
@codereport
Copy link
Contributor Author

rerun tests

@codereport
Copy link
Contributor Author

rerun tests

@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 96a905c into rapidsai:branch-21.08 Jul 6, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@cwharris cwharris cwharris approved these changes

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codereport @rongou @cwharris @dillon-cullinan