Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers that use std::thread now include <thread> #938

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Headers that use std::thread now include <thread> #938

merged 1 commit into from
Jan 5, 2022

Conversation

robertmaynard
Copy link
Contributor

Fixes #937

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Jan 5, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner January 5, 2022 13:28
@robertmaynard robertmaynard added this to PR-WIP in v22.02 Release via automation Jan 5, 2022
@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 5, 2022
@robertmaynard
Copy link
Contributor Author

@kkraus14

v22.02 Release automation moved this from PR-WIP to PR-Reviewer approved Jan 5, 2022
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8c5ed6a into rapidsai:branch-22.02 Jan 5, 2022
v22.02 Release automation moved this from PR-Reviewer approved to Done Jan 5, 2022
@robertmaynard robertmaynard deleted the bug/include_missing_thread_includes branch January 5, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@codereport codereport codereport approved these changes

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
No open projects
v22.02 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] std::thread is used without #include <thread>
5 participants
@robertmaynard @rongou @kkraus14 @jrhemstad @codereport