Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ccache with sccache #963

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Replace ccache with sccache #963

merged 5 commits into from
Feb 3, 2022

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Jan 27, 2022 •
edited
Loading

This PR replaces ccache with sccache. The reason for the replacement is to reduce the complexity involved in the CI backend to manually move around ccache tarballs.

@ajschmidt8
Replace ccache with sccache
14a4a96 
This PR replaces `ccache` with `sccache`.
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed gpuCI conda labels Jan 27, 2022
@ajschmidt8
Copy link
Member Author

ajschmidt8 commented Jan 27, 2022 •
edited
Loading

pre-cache C++ build time (link to job): 0:06:31.6

image

@ajschmidt8
Copy link
Member Author

rerun tests

@ajschmidt8
Copy link
Member Author

Looks like I'll need to add some additional flags to the conda build command in this repo to ensure that the paths stay consistent between builds (and therefore enable sccache cache hits).

@ajschmidt8 ajschmidt8 added this to PR-WIP in v22.04 Release via automation Jan 28, 2022
@ajschmidt8 ajschmidt8 force-pushed the sccache branch 2 times, most recently from a6a0509 to 81fbc56 Compare January 28, 2022 16:24
@ajschmidt8
Copy link
Member Author

pre-cache C++ build time (link to job): 0:06:31.6

post-cache C++ build time (link to job): 0:00:29.1

image

Seems that sccache is working correctly!

@ajschmidt8 ajschmidt8 marked this pull request as ready for review January 28, 2022 18:33
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner January 28, 2022 18:33
v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Jan 28, 2022
AyodeAwe
AyodeAwe approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ajschmidt8 ajschmidt8 added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 1, 2022
@ajschmidt8
Copy link
Member Author

PR is ready for review, but we'll wait to merge until all the other PRs are confirmed working as well.

@ajschmidt8 ajschmidt8 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 3, 2022
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc2a544 into rapidsai:branch-22.04 Feb 3, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 3, 2022
@ajschmidt8 ajschmidt8 deleted the sccache branch February 3, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
conda gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajschmidt8 @raydouglass @AyodeAwe