Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake install rules for tests #969

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

ajschmidt8
Copy link
Member

This PR adds a CMake install rule for test and benchmark targets. This step is a prerequisite to being able to package tests/benchmarks in their own conda package, which will enable us to deprecate Project Flash.

@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 2, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner February 2, 2022 19:03
@github-actions github-actions bot added CMake cpp Pertains to C++ code labels Feb 2, 2022
@ajschmidt8 ajschmidt8 added this to PR-WIP in v22.04 Release via automation Feb 2, 2022
This PR adds a CMake `install` rule for test and benchmark targets. This step is a prerequisite to being able to package tests/benchmarks in their own `conda` package, which will enable us to deprecate _Project Flash_.
benchmarks/CMakeLists.txt Show resolved Hide resolved
benchmarks/CMakeLists.txt Show resolved Hide resolved
v22.04 Release automation moved this from PR-WIP to PR-Needs review Feb 7, 2022
@robertmaynard robertmaynard self-requested a review February 7, 2022 15:48
v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 7, 2022
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 514f4b4 into rapidsai:branch-22.04 Feb 7, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 7, 2022
@ajschmidt8 ajschmidt8 deleted the add-install-rules branch February 7, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants