Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Python requirements in setup.cfg and rmm_dev.yml #982

Merged
merged 8 commits into from
Mar 21, 2022
Merged

Bump Python requirements in setup.cfg and rmm_dev.yml #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe57b4a
Bump Python requirements in setup.cfg
shwina Feb 15, 2022
68f32c9
Other 3.7 references
shwina Feb 15, 2022
eb6560b
Remove upper bound from setup.cfg
shwina Feb 15, 2022
741232b
Update conda/environments/rmm_dev_cuda11.5.yml
shwina Feb 15, 2022
f07e176
Merge branch 'branch-22.04' of https://github.com/rapidsai/rmm into b…
shwina Feb 15, 2022
111339a
Update 11.6 dev yml
shwina Feb 15, 2022
3f7d08b
Merge branch 'bump-python-310-setupcfg' of github.com:shwina/rmm into…
shwina Feb 15, 2022
3154ebb
Update README.md
shwina Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ conda install -c nvidia -c rapidsai -c conda-forge \
We also provide [nightly Conda packages](https://anaconda.org/rapidsai-nightly) built from the HEAD
of our latest development branch.

Note: RMM is supported only on Linux, and with Python versions 3.7 and later.
Note: RMM is supported only on Linux, and only tested with Python versions 3.8 and 3.9.


Note: The RMM package from Conda requires building with GCC 9 or later. Otherwise, your application may fail to build.

Expand Down
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda11.5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- flake8=3.8.3
- black=19.10
- isort=5.6.4
- python>=3.7,<3.9
- python>=3.8,<3.10
vyasr marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the upper bound here? Just wondering since we are dropping elsewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- these are the .yml files used to create dev environments. Since we don't typically want development with 3.10, we keep the upper bound here. This doesn't stop developers from manually building RMM with Python 3.10 if they desire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to do something like the following?

conda create -f rmm_dev_env.yml python=3.9

If so, we can (in theory) drop the upper bound here and make it the developer's responsibility to specify which Python they want to use.

Copy link
Contributor

@bdice bdice Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a good idea — I have seen other packages specify a yml with a user-provided python spec (edit: apparently this is not a thing, I was wrong). Then update the README/docs to include that specification in the commands to create a conda environment.

On that note, it might even make sense to remove the upper bound (use >=11.5) for cudatoolkit and recommend that users pick their version as needed, instead of maintaining two environment files for 11.5 and 11.6.

Copy link
Contributor Author

@shwina shwina Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is that a valid conda command, and does it do the expected thing here (override the python spec in the .yml?)

This comment was marked as outdated.

Sign in to view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn. @shwina I could have sworn I had seen this before but the specifiers after -f stuff.yml are ignored, so you can't do what I was suggesting. Sorry about that. 😢

- numba>=0.49
- numpy
- cffi>=1.10.0
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda11.6.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- flake8=3.8.3
- black=19.10
- isort=5.6.4
- python>=3.7,<3.9
- python>=3.8,<3.10
- numba>=0.49
- numpy
- cffi>=1.10.0
Expand Down
2 changes: 1 addition & 1 deletion python/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ packages = find:
install_requires =
numpy
numba>=0.49
python_requires = >=3.7,<3.9
python_requires = >=3.8
vyasr marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ def build_extensions(self):
"Topic :: Scientific/Engineering",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
],
# Include the separately-compiled shared library
setup_requires=["Cython>=0.29,<0.30"],
Expand Down