Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda-python dependency to pyproject.toml #994

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Add cuda-python dependency to pyproject.toml #994

merged 1 commit into from
Mar 14, 2022

Conversation

sevagh
Copy link
Contributor

@sevagh sevagh commented Mar 14, 2022

When trying to install rmm with pip using the git url, I ran into some Cython CUDA compile errors:

(rapids) root@5a38f55ffbdd:/rmm/python#  pip install -e 'git+https://github.com/rapidsai/rmm.git@branch-22.04#egg=rmm&subdirectory=python'
...
/src/rmm/python/rmm/_lib/cuda_stream.pxd:16:0: 'cuda/ccudart.pxd' not found
        Error compiling Cython file:
        ------------------------------------------------------------
        cimport cython
        from cuda.ccudart cimport cudaStream_t
        ^
...

Adding cuda-python to the pyproject.toml requires (as suggested by @vyasr and @shwina) helped solve the issue:

(rapids) root@5a38f55ffbdd:/rmm/python# pip install .
Processing /rmm/python
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
...
(rapids) root@5a38f55ffbdd:/rmm/python# python -c 'import rmm; buf = rmm.DeviceBuffer(size=100); print(buf.size); print(buf.ptr)'
100
140379508703232
(rapids) root@5a38f55ffbdd:/rmm/python#

@sevagh sevagh requested a review from a team as a code owner March 14, 2022 16:16
@github-actions github-actions bot added the Python Related to RMM Python API label Mar 14, 2022
@vyasr vyasr added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Mar 14, 2022
@sevagh sevagh requested a review from shwina March 14, 2022 17:44
@shwina
Copy link
Contributor

shwina commented Mar 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4997097 into rapidsai:branch-22.04 Mar 14, 2022
@jakirkham
Copy link
Member

Thanks Sevag! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants