Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no_cma/has_cma variants #996

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

ajschmidt8
Copy link
Member

Depends on #990.

Once #990 is merged, we should no longer need the no_cma/has_cma rmm package variants. This PR removes the two variants.

@ajschmidt8
Copy link
Member Author

Keeping as a draft in case these changes are decided to be included in #990.

@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 16, 2022
@robertmaynard
Copy link
Contributor

We should remove the root directory build.sh cma hooks as well. Plus we can remove the root CMakeLists.txt and the python/CMakeLists.txt usage of CUDA_MALLOC_ASYNC_SUPPORT

Depends on rapidsai#990.

Once rapidsai#990 is merged, we should no longer need the `no_cma`/`has_cma` `rmm` package variants. This PR removes the two variants.
@github-actions github-actions bot added CMake conda cpp Pertains to C++ code Python Related to RMM Python API labels Mar 17, 2022
@ajschmidt8
Copy link
Member Author

We should remove the root directory build.sh cma hooks as well. Plus we can remove the root CMakeLists.txt and the python/CMakeLists.txt usage of CUDA_MALLOC_ASYNC_SUPPORT

removed in 5425c47

@ajschmidt8 ajschmidt8 marked this pull request as ready for review March 18, 2022 13:42
@ajschmidt8 ajschmidt8 requested review from a team as code owners March 18, 2022 13:42
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f358d5a into rapidsai:branch-22.04 Mar 18, 2022
@ajschmidt8 ajschmidt8 deleted the rm-cma-variants branch March 18, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants