Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CentOS 7 from workflows. #192

Merged
merged 2 commits into from Mar 19, 2024
Merged

Drop CentOS 7 from workflows. #192

merged 2 commits into from Mar 19, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 15, 2024

This PR drops CentOS 7. See rapidsai/build-planning#23.

@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 15, 2024 23:09
@bdice
Copy link
Contributor Author

bdice commented Mar 15, 2024

@jameslamb @ajschmidt8 @vyasr Feel free to weigh in on this set of matrix changes. I replaced centos7 with rockylinux8 and made a few small tweaks to redistribute OS versions. The Python and C++ test matrices are now exactly equivalent, too.

@bdice bdice marked this pull request as ready for review March 15, 2024 23:26
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a some kind of chart somewhere that we check against to know how much of an ideal spread across supported OS’s/combinations we’re getting for our tests?

@bdice
Copy link
Contributor Author

bdice commented Mar 19, 2024

@AyodeAwe Good question. We don't have a chart, but this is the process we used last time we reconfigured the CI matrix: rapidsai/build-planning#5 (comment)

There is also a lot of discussion on #184.

@bdice bdice merged commit 82cc336 into branch-24.06 Mar 19, 2024
@jameslamb
Copy link
Member

Sorry I wasn't able to get to this yesterday. Changes look good to me 👍🏻

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Mar 20, 2024
This PR tests rapidsai/shared-workflows#192, which drops CentOS 7 support. See rapidsai/build-planning#23.

This PR removes the logic needed to build and test both `manylinux_2_17` and `manylinux_2_28` wheels, as we will only be building for `manylinux_2_28`.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #15323
@ajschmidt8 ajschmidt8 deleted the drop-centos7 branch March 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants