Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning strategy #997

Merged
merged 17 commits into from
Oct 31, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 13, 2023

@vyasr vyasr self-assigned this Oct 13, 2023
@vyasr vyasr requested review from a team as code owners October 13, 2023 22:01
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 13, 2023
ucp/_version.py Outdated Show resolved Hide resolved
Co-authored-by: Peter Andreas Entschev <peter@entschev.com>
@vyasr vyasr requested a review from pentschev October 16, 2023 18:05
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr left a few questions regarding the discrepancy in RAPIDS and UCX-Py versions, not sure if they're being addressed externally or if we need extra steps here to get the proper UCX-Py version.

ci/build_python.sh Show resolved Hide resolved
ci/build_wheel.sh Show resolved Hide resolved
conda/recipes/ucx-py/meta.yaml Outdated Show resolved Hide resolved
@pentschev
Copy link
Member

@vyasr I see you've updated the release script in 3ee156e . I'm assuming now that rapids-generate-version and RAPIDS_PACKAGE_VERSION will pick up the version that was actually set via the release script, is that correct or are there other changes needed here still?

@vyasr
Copy link
Contributor Author

vyasr commented Oct 17, 2023

@vyasr I see you've updated the release script in 3ee156e . I'm assuming now that rapids-generate-version and RAPIDS_PACKAGE_VERSION will pick up the version that was actually set via the release script, is that correct or are there other changes needed here still?

No and yes 🙂

  • No because the versions are based on the tags on the repo, not the version contained in _version.py
  • Yes that we're good without needing further changes because it's tag-based.

@vyasr vyasr requested a review from pentschev October 17, 2023 17:49
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vyasr !

@pentschev
Copy link
Member

BTW, the RTD failure is being addressed by #999 .

@vyasr
Copy link
Contributor Author

vyasr commented Oct 17, 2023

Great, thanks! Let's hold off merging for the moment (as per the label), we have PRs like this open across RAPIDS and in case any additional good feedback comes in on one of them we'll want to apply it consistently to the other repos too.

ci/release/update-version.sh Outdated Show resolved Hide resolved
ucp/_version.py Outdated Show resolved Hide resolved
@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 27, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Oct 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit c6ab353 into rapidsai:branch-0.35 Oct 31, 2023
33 checks passed
@vyasr vyasr deleted the feat/nightly_versions branch October 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants