Skip to content

Test and document contrib.handlers #220

Closed
copelco opened this Issue Nov 28, 2012 · 2 comments

3 participants

@copelco
RapidSMS member
copelco commented Nov 28, 2012
  • Add docs under docs/topics/contrib/handlers.rst with app overview.
    • Include installation procedure.
    • Include description and example uses of BaseHandler, KeywordHandler, PatternHandler
    • Document INSTALLED_HANDLERS, EXCLUDED_HANDLERS, and RAPIDSMS_HANDLERS_EXCLUDE_APPS settings
    • Update docs/index.rst with proper link to new page.
  • Add tests under lib/rapidsms/contrib/handlers/tests.py and make sure we have adequate test coverage
  • PEP8 fixes
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
@rebecca-caktus rebecca-caktus refs #220 - Updated rapidsms.contrib.handlers docs
Based on comments from @dpoirier.
d62ad23
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
@rebecca-caktus rebecca-caktus refs #220 - Moved app start logic to __init__
Since the start() method is being deprecated.
07098c4
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
@rebecca-caktus rebecca-caktus refs #220 - Fixed implementation of INCLUDED_HANDLERS
And other small fixes to handlers utils.
41a55cd
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
@rebecca-caktus rebecca-caktus refs #220 - Updated KeywordHandler example a9b0e65
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 29, 2013
@rebecca-caktus rebecca-caktus refs #220 - Added missing section labels to docs b30870e
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 29, 2013
@rebecca-caktus rebecca-caktus refs #220 - Removed extra line from docs d43c41a
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 30, 2013
@rebecca-caktus rebecca-caktus refs #220 - Updated PatternHandler note
In response to comments from @copelco.
9463369
@rebecca-caktus rebecca-caktus added a commit to caktus/rapidsms that referenced this issue Jan 30, 2013
@rebecca-caktus rebecca-caktus Revert "refs #220 - Raise error when INSTALLED_HANDLER cannot be matc…
…hed"

This reverts commit 49005bf.
c51fed4
@mlavin
mlavin commented Feb 21, 2013

I had another case open for this but I see this is already slated for v0.13. See #265.

@dpoirier
RapidSMS member
dpoirier commented Mar 4, 2013

Has been merged into release-0.12.0

@dpoirier dpoirier closed this Mar 4, 2013
@rebecca-caktus rebecca-caktus added a commit that referenced this issue Mar 11, 2013
@rebecca-caktus rebecca-caktus Better docs for BaseHandler.test
This was mentioned in #265 and #220 but those issues were closed before the change was made.
e1d35dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.