Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and document contrib.handlers #220

Closed
copelco opened this issue Nov 28, 2012 · 2 comments
Closed

Test and document contrib.handlers #220

copelco opened this issue Nov 28, 2012 · 2 comments
Labels
contrib documentation
Milestone
v0.12.0 - Twitter...

Comments

@copelco
Copy link
Member

copelco commented Nov 28, 2012

  • Add docs under docs/topics/contrib/handlers.rst with app overview.
    • Include installation procedure.
    • Include description and example uses of BaseHandler, KeywordHandler, PatternHandler
    • Document INSTALLED_HANDLERS, EXCLUDED_HANDLERS, and RAPIDSMS_HANDLERS_EXCLUDE_APPS settings
    • Update docs/index.rst with proper link to new page.
  • Add tests under lib/rapidsms/contrib/handlers/tests.py and make sure we have adequate test coverage
  • PEP8 fixes
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Updated docs for rapidsms.contrib.handlers
1fd2c6e
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - PEP8 style changes for rapidsms.contrib.handlers
a46cd55
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Additional tests for rapidsms.contrib.handlers
4ecfc6f
@ghost ghost mentioned this issue Jan 28, 2013
Merged
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Updated rapidsms.contrib.handlers docs
d62ad23 
Based on comments from @dpoirier.
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Moved app start logic to __init__
07098c4 
Since the start() method is being deprecated.
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Raise an error when pattern/keyword is not defined
31a3195
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Fixed implementation of INCLUDED_HANDLERS
41a55cd 
And other small fixes to handlers utils.
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Updated KeywordHandler example
a9b0e65
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 28, 2013
refs rapidsms#220 - Raise error when INSTALLED_HANDLER cannot be matched
49005bf
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 29, 2013
refs rapidsms#220 - Added missing section labels to docs
b30870e
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 29, 2013
refs rapidsms#220 - Removed extra line from docs
d43c41a
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 30, 2013
refs rapidsms#220 - Updated PatternHandler note
9463369 
In response to comments from @copelco.
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 30, 2013
Revert "refs rapidsms#220 - Raise error when INSTALLED_HANDLER cannot…
c51fed4 
… be matched"

This reverts commit 49005bf.
ghost pushed a commit to caktus/rapidsms that referenced this issue Jan 30, 2013
refs rapidsms#220 - Updated docs in response to comments from @copelco
49284ed
copelco added a commit that referenced this issue Feb 8, 2013
@copelco
Merge pull request #248 from caktus/docs/contrib/handlers
6ab7b87 
refs #220 - Tests and docs for rapidsms.contrib.handlers
@mlavin mlavin mentioned this issue Feb 21, 2013
Closed
@mlavin
Copy link

mlavin commented Feb 21, 2013

I had another case open for this but I see this is already slated for v0.13. See #265.

@dpoirier
Copy link
Member

dpoirier commented Mar 4, 2013

Has been merged into release-0.12.0

@dpoirier dpoirier closed this as completed Mar 4, 2013
ghost pushed a commit that referenced this issue Mar 11, 2013
Better docs for BaseHandler.test
e1d35dd 
This was mentioned in #265 and #220 but those issues were closed before the change was made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib documentation
Projects
None yet
Milestone
v0.12.0 - Twitter Bootstrap
Development

No branches or pull requests
3 participants
@copelco @mlavin @dpoirier