Update form styles #340
Update form styles #340
Conversation
ghost
assigned 
|
I think we can get rid of forms.css. I clicked around our contrib app pages that have forms and looked at what styles were applied (using Chrome Inspect Element) and didn't see anything from forms.css being used. I conclude that bootstrap is overriding everything we were setting in forms.css, so it's redundant. There are some other stylesheets, like tables.css and modules.css, that still seem to be used. We could modify the contrib apps to work with pure bootstrap, but there could be other RapidSMS apps out there that rely on these styles, since apparently bootstrap isn't overriding everything there. So I think we should just keep those for now. |
I clicked around our contrib app pages that have forms and looked at what styles were applied (using Chrome Inspect Element) and didn't see anything from forms.css being used. I conclude that bootstrap is overriding everything we were setting in forms.css, so it's redundant.
|
I noticed that the borders around forms go away, but that seems fine. I couldn't find templates using style from splits.css, modules.css, or icons.css. Did you find them used somewhere? |
|
Locations uses some of the styles from splits.css, icons.css, and modules.css. I also worry that lots of existing apps that our users have written probably still use them. They probably haven't dived in headlong and re-done their styling for bootstrap yet. |
|
The consensus in our meeting Friday was to move these style files into the locations app and stop including them from the base template. If people are still using them, they'll have to include them themselves instead of getting them from the base template, but other apps won't be loading them by default anymore and then not using them. |
- Stop loading old stylesheets in base RapidSMS template - Move the old stylesheet files to the locations app - Load the old stylesheets from the locations app's base template - Modify the table styling in a few other contrib apps' code to take advantage of bootstrap - Add a backwards incompatibility note to the 0.15 release notes.
|
I moved the stylesheets to locations, and modified our other apps to add the style classes on their tables to trigger Bootstrap styling. @lemanal this is ready to review again. |
|
Might be nice to cleanup & get the module CSS & divs out of dashboard.html. Otherwise, this looks great. |
|
I opened issue #401 to cleanup dashboard.html. I agree it would be good to do that. |
forms.csshas not been updated since Bootstrap was added. Some of these styles seem to be out of date.