Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask out token in logging #129

Merged
merged 1 commit into from
Feb 7, 2022
Merged

feat: mask out token in logging #129

merged 1 commit into from
Feb 7, 2022

Conversation

rapiz1
Copy link
Owner

@rapiz1 rapiz1 commented Feb 7, 2022

token, default_token, local_private_key will be logged as MASKED even if it's in debug level.

like:

DEBUG rathole: Config { server: Some(ServerConfig { bind_addr: "0.0.0.0:2333", default_token: Some(MASKED), services: {"foo1": ServerServiceConfig { service_type: Tcp, name: "foo1", bind_addr: "0.0.0.0:5202", token: Some(MASKED), nodelay: None }}, transport: TransportConfig { transport_type: Noise, nodelay: false, keepalive_secs: 10, keepalive_interval: 3, tls: None, noise: Some(NoiseConfig { pattern: "Noise_NK_25519_ChaChaPoly_BLAKE2s", local_private_key: Some(MASKED), remote_public_key: None }) } }), client: None }

Resolves #128

@rapiz1 rapiz1 enabled auto-merge (squash) February 7, 2022 12:00
@rapiz1 rapiz1 merged commit 5f301ed into main Feb 7, 2022
@rapiz1 rapiz1 deleted the mask branch February 7, 2022 12:01
cssivision pushed a commit to cssivision/rathole that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret token is logged
1 participant