Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search to Default Live #1517

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Nov 1, 2023

Defaults Search box to "Live" rather than "Defer" to match V2

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe mentioned this pull request Nov 1, 2023
9 tasks
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1517 (d7d41cb) into develop (1c86792) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #1517   +/-   ##
==========================================
  Coverage      88.53%   88.53%           
  Complexity      1254     1254           
==========================================
  Files             95       95           
  Lines           2975     2975           
==========================================
  Hits            2634     2634           
  Misses           341      341           
Files Coverage Δ
src/Traits/Helpers/SearchHelpers.php 98.14% <100.00%> (ø)

@lrljoe lrljoe merged commit 29885e6 into rappasoft:develop Nov 1, 2023
6 checks passed
@lrljoe lrljoe deleted the v3-DefaultSearchToLive branch November 1, 2023 21:39
@lrljoe lrljoe linked an issue Nov 1, 2023 that may be closed by this pull request
lrljoe added a commit that referenced this pull request Nov 2, 2023
* v3-Move ConfigurableAreas to Own Section WithConfigurableAreas (#1510)

* Move ConfigurableAreas to Own Trait

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and  TableAttributes (#1514)

* Splitting ConfigurableAreas into Traits

* Splitting TableAttributes into Traits

* Splitting CollapsingColumns into Traits

* Add HasAllTraits Trait


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* V3 - Filter DTOs (#1503)

* Initial Update - Using DTO

* Add filterGenericData

* Remove requirement for method on render for Filter

* Remove Render requirement

* GenericHeaderTest

* Add filter comparison

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update Search to Default Live (#1517)

* Update Search to Default Live

* Search Live Default - Test Fixes

* V3 add custom filter view (#1518)

* Add viewPath for Filters

* Update Filter ViewPath

* Add available methods for setCustomView

* Add Tests

* Migrate Column/Filter View properties to IsColumn & IsFilter traits to standardise

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* V3 Rename row-contents blades (#1519)

* Rename row-contents to collapsed-columns

* Update Change Log

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search param is broken after V3 upgrade
1 participant