Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Initial Lifecycle Hooks - Configuring/Configured #1520

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Nov 2, 2023

This adds the first of the Hook collection planned, providing a hook for:

  • configuring() - fires before configure()
    and
  • configured() - fires after configure()

Per standard Livewire behaviour, these can be used either in your Data Table, or a Trait.l

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1520 (8a1676f) into develop (f2b5794) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             develop    #1520      +/-   ##
=============================================
- Coverage      88.55%   88.53%   -0.03%     
- Complexity      1256     1261       +5     
=============================================
  Files             95       96       +1     
  Lines           2980     2992      +12     
=============================================
+ Hits            2639     2649      +10     
- Misses           341      343       +2     
Files Coverage Δ
src/DataTableComponent.php 97.14% <100.00%> (+0.36%) ⬆️
src/Traits/WithTableHooks.php 75.00% <75.00%> (ø)

@lrljoe lrljoe merged commit 6c1b4f9 into rappasoft:develop Nov 2, 2023
6 checks passed
lrljoe added a commit that referenced this pull request Nov 3, 2023
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured #1520
Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes #1514
Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades #1519
Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant