Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 Clean up maps, tests #1536

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Nov 3, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1536 (642b435) into develop (3a3b42c) will increase coverage by 0.18%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1536      +/-   ##
=============================================
+ Coverage      88.80%   88.98%   +0.18%     
+ Complexity      1266     1264       -2     
=============================================
  Files             96       96              
  Lines           3001     2997       -4     
=============================================
+ Hits            2665     2667       +2     
+ Misses           336      330       -6     
Files Coverage Δ
src/Mechanisms/RappasoftFrontendAssets.php 100.00% <ø> (+6.77%) ⬆️

... and 2 files with indirect coverage changes

@lrljoe lrljoe merged commit f73b59e into rappasoft:develop Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant