Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 Splitting of JS Files #1558

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Nov 18, 2023

This:

  1. Splits up the core JS functions into individual files for ease of maintenance.
  2. Modifies several entangled items to no longer be live

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe linked an issue Nov 18, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6a69d6) 88.99% compared to head (46e14da) 88.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1558   +/-   ##
==========================================
  Coverage      88.99%   88.99%           
  Complexity      1268     1268           
==========================================
  Files             96       96           
  Lines           3008     3008           
==========================================
  Hits            2677     2677           
  Misses           331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe added bug Something isn't working enhancement New feature or request Version 3 Version 3 of Package labels Nov 18, 2023
@lrljoe lrljoe merged commit 1e6bbda into rappasoft:develop Nov 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Version 3 Version 3 of Package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Using NumberRangeFilter causes an extra update() call on boot
1 participant