Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rowsRetrieved Lifecycle Hook #1578

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Dec 4, 2023

  • Add a new Lifecycle Hook for rowsRetrieved
  • Update Docs for Lifecycle Hooks
  • Update Changelog for recent PRs

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d573049) 88.98% compared to head (6157a6f) 89.00%.
Report is 12 commits behind head on develop.

Files Patch % Lines
config/livewire-tables.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1578      +/-   ##
=============================================
+ Coverage      88.98%   89.00%   +0.01%     
- Complexity      1264     1268       +4     
=============================================
  Files             96       96              
  Lines           2997     3010      +13     
=============================================
+ Hits            2667     2679      +12     
- Misses           330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 55f7d36 into rappasoft:develop Dec 4, 2023
6 checks passed
@lrljoe lrljoe mentioned this pull request Dec 4, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant