Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just fixing a minor output issue #30

Closed
wants to merge 5 commits into from
Closed

Conversation

DerekHAu
Copy link

When CRM has "[" or "]" in an enum text, the generated class is invalid.
Have added them to the global replace list

@DerekHAu
Copy link
Author

I also accidentally included another fix I was going to do another PR for (this is my first time doing a PR for any project and I haven't used Git much before)… I was encountering issues with optionsets having duplicate text values (even Microsoft have some in the Duplicate Detection entities) so now suffix any duplicate entries with "Duplicate" and the option set value to ensure uniqueness (the first optionset entry is untouched)

@rappen
Copy link
Owner

rappen commented May 15, 2019

Thanks @DerekHAu, great addition!
I don't see in the changed files anything regarding the duplicate thing you mentioned, so it does not seem included in this PR after all :)
https://github.com/rappen/LateboundConstantsGenerator/pull/30/files

Your PR had a few different commits, including adding the user specific project file. So if you don't mind I will grab the change you made and add it directly in the master branch, and decline the pull request?
Credit will be properly attributed anyway :)

@rappen rappen closed this in c259e98 Jun 26, 2019
@rappen
Copy link
Owner

rappen commented Jun 26, 2019

This fix is now published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants