Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make topoRank field public #37

Closed
raquo opened this issue Sep 9, 2020 · 3 comments
Closed

Make topoRank field public #37

raquo opened this issue Sep 9, 2020 · 3 comments

Comments

@raquo
Copy link
Owner

raquo commented Sep 9, 2020

val topoRank being protected[airstream] prevents users from extending EventStream or Signal, which is silly. The field should probably just be public.

EDIT: Is this actually true? I think I confused something. People are extending EventStream just fine it seems.

@narma
Copy link

narma commented Dec 25, 2020

It's actually true, I can make custom Observable only under com.raquo.airstream package, which is not good practice.

@raquo
Copy link
Owner Author

raquo commented Dec 25, 2020

@narma I think you can overcome this issue by saying override val topoRank (not override protected[airstream] val topoRank). Seems to compile in 2.13 at least.

@raquo
Copy link
Owner Author

raquo commented Feb 26, 2021

This is now documented in the docs, and with the new CustomSource API extending observables shouldn't be as common.

Also, for reading topoRank, there's a static Observable.debugTopoRank(obs) method now

@raquo raquo closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants