Fix: call willSetParent earlier in case of append

raquo · Apr 13, 2018 · cec6977 · cec6977
1 parent bbf4601
commit cec6977
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/shared/src/main/scala/com/raquo/dombuilder/generic/nodes/ParentNode.scala b/shared/src/main/scala/com/raquo/dombuilder/generic/nodes/ParentNode.scala
@@ -16,11 +16,12 @@ trait ParentNode[N, +Ref <: BaseRef, BaseRef] extends Node[N, Ref, BaseRef] { th
 
   /** @return Whether child was successfully appended */
   def appendChild(child: BaseChildNode)(implicit treeApi: TreeApi[N, BaseRef]): Boolean = {
+    val nextParent = Some(this)
+    child.willSetParent(nextParent)
+
     // 1. Update DOM
     val appended = treeApi.appendChild(parent = this, child = child)
     if (appended) {
-      val nextParent = Some(this)
-      child.willSetParent(nextParent)
 
       // 2. Update this node
       if (_maybeChildren.isEmpty) {