Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key renaming proposals #51

Closed
raquo opened this issue May 6, 2019 · 4 comments · Fixed by #57
Closed

Key renaming proposals #51

raquo opened this issue May 6, 2019 · 4 comments · Fixed by #57

Comments

@raquo
Copy link
Owner

raquo commented May 6, 2019

So I guess we'll be collecting a few attr renaming proposals here?

id -> idAttr

Not sure if id reflected attribute is pulling its weight hogging up what could be the most common term name.

Variable shadowing is annoying in cases like valueByIdMap.map { case (id, value) => ... }.

Personally I'm not annoyed enough to change it yet. If anyone has a preference one way or another please let me know.

@cornerman
Copy link
Contributor

I'll just throw in my opinion. I rarely use the id attribute in my code, therefore I am in favor of renaming the attribute to idAttr. For me, the usage pattern does not justify such a prominent name. Main factors are variable shadowing and surprises when moving code which use a variable named id.

@raquo raquo changed the title Proposal: rename id to idAttr Pending renaming proposals Dec 12, 2019
@raquo raquo changed the title Pending renaming proposals Pending key renaming proposals Dec 12, 2019
@raquo
Copy link
Owner Author

raquo commented Dec 12, 2019

name -> nameAttr

Basically same logic as id. If one is renamed the other should probably be too.

@raquo raquo changed the title Pending key renaming proposals Key renaming proposals Dec 12, 2019
@raquo
Copy link
Owner Author

raquo commented Mar 16, 2020

param -> paramTag

Very niche tag hogging a good name. Specifically, conflicts with URL DSL's query param name used in Waypoint.

map -> mapTag

Very niche tag hogging a good name.

object -> objectTag

Requires backticks the way it is

@fdietze
Copy link
Contributor

fdietze commented Mar 23, 2020

I agree to all the renames!

@raquo raquo closed this as completed in #57 Mar 29, 2020
raquo added a commit that referenced this issue Feb 9, 2023
This was promised back in #51 but I must have missed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants