Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css file needs be exported in package.json #78

Closed
mshima opened this issue Mar 26, 2024 · 2 comments
Closed

css file needs be exported in package.json #78

mshima opened this issue Mar 26, 2024 · 2 comments

Comments

@mshima
Copy link

mshima commented Mar 26, 2024

If I add @import 'ngx-diff/styles/default-theme'; to scss file.
The module is not found:
image

If I add @import 'ngx-diff/styles/default-theme.css'; to scss file.
The file is not exported.
image

If I add "./styles/*": "./styles/*.css", to package.json's export, @import 'ngx-diff/styles/default-theme'; works.

@mshima mshima changed the title css should be exported in package.json css file needs be exported in package.json Mar 26, 2024
rars added a commit that referenced this issue Mar 27, 2024
@rars
Copy link
Owner

rars commented Mar 27, 2024

Hi @mshima, thanks for reporting this. I've published a fix with an update to the exports section in https://github.com/rars/ngx-diff/releases/tag/v8.0.2. Please let me know if you're still encountering problems with this.

@mshima
Copy link
Author

mshima commented Mar 27, 2024

Working as expected now.
Thanks.

@mshima mshima closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants