from_trigger_intent slot mapping with an active_loop condition fills the slot only when that form gets activated

[ancalita]

Proposed changes:

• Fix for ATO-334, reported issue that slot with a from_trigger_intent mapping with an active_loop condition was being filled, despite that particular form not being activated.

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[github-actions]

🚀 A preview of the docs have been deployed at the following URL: https://11588--rasahq-docs-rasa-v2.netlify.app/docs/rasa

[tmbo]

lgtm

[znat]

LGTM, just wondering if we can have an easier to read condition when deciding to fill slots with FROM_TRIGGER_INTENT mapping

[znat]

Can this be simplified to a single if statement? Something like:

if (tracker.active_loop_name is None 
    or active_loops_in_mapping_conditions
    and tracker.active_loop_name 
    and (tracker.active_loop_name not in active_loops_in_mapping_conditions)
):
       trigger_mapping_condition_met = False

IIUC we want to make sure that:

• There's an active loop
  AND either/or:
• a condition states that we should only fill for the current active loop
• no condition is set for any other form

May be something like this would work then:

should_fill_trigger_slot = (
  mapping_type == SlotMappingType.FROM_TRIGGER_INTENT
  and tracker.active_loop_name 
  and (tracker.active_loop_name in active_loops_in_mapping_conditions if active_loops_in_mapping_conditions else True)
    )

[znat]

Why is this warning irrelevant when mapping FROM_TRIGGER_INTENT?

[ancalita]

This is irrelevant, because it's not necessary to add the slot with FROM_TRIGGER_INTENT mapping to the form's required_slots (since it gets filled automatically at form activation without it being requested by the form) and at the same time we want to allow a FROM_TRIGGER_INTENT filled slot to specify in which form context they should be filled via a mapping condition.

While this validation check is meant for any other slot mapping type that has mapping conditions specified and should be part of the form's required_slots, it's not applicable for this FROM_TRIGGER_INTENT mapping.